Integrate postcard support into proc-macro server CLI #20986
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
Shourya742
changed the title
Shourya742
changed the title
Shourya742
force-pushed
the
2025-11-07-add-support-for-postcard
branch
3 times, most recently
from
75a35ea to
15b818d
Compare
rustbot
added
the
S-waiting-on-review
Shourya742
force-pushed
the
2025-11-07-add-support-for-postcard
branch
5 times, most recently
from
203a757 to
6065248
Compare
Shourya742
force-pushed
the
2025-11-07-add-support-for-postcard
branch
5 times, most recently
from
477abf2 to
470b87b
Compare
Shourya742
force-pushed
the
2025-11-07-add-support-for-postcard
branch
2 times, most recently
from
c666eef to
aa34990
Compare
| let create_srv = || { | ||
| let mut process = Process::run(process_path, env.clone())?; | ||
| let mut srv = { | ||
| let mut process = match Process::run(process_path, env.clone(), &protocol) { |
There was a problem hiding this comment.
So I just checked something and it seems I messed up the cli parsing in the proc-macro server. It doesnt validate things so it always spawns successfully. Given you did this hcange in the version check as well it seems you noticed that though, so that should work out I tihnk 👍
There was a problem hiding this comment.
It struck me a bit later while reviewing the code that we basically accept any garbage after --format, apart from the valid values. That was actually going to be my next PR idea. 😄
There was a problem hiding this comment.
Would love a fix for that for sure as a follow up :)
Shourya742
force-pushed
the
2025-11-07-add-support-for-postcard
branch
from
aa34990 to
cae902c
Compare
Veykril
left a comment
Veykril
left a comment
There was a problem hiding this comment.
Alright, looks good to me now, thanks!
|
Also cc @jamesmunns |
|
I'll need to catch up on the history here, but if you want something a bit more protocol'y structured, I've been working on |
rustbot
removed
the
S-waiting-on-review
4 participants
This PR introduces a postcard binary transport layer for communication between the proc-macro client and server.