Skip to content

Fix complete unit return semicolon in arg-list #21032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix complete unit return semicolon in arg-list #21032

wants to merge 1 commit into from

Conversation

@A4-Tacks
Copy link
Member

@A4-Tacks A4-Tacks commented Nov 13, 2025 •
edited by rustbot
Loading

Fixes #20987

Example

fn foo() {}
fn baz(_: impl FnOnce()) {}
fn bar() {
    baz(fo$0);
}

Before this PR

fn foo() {}
fn baz(_: impl FnOnce()) {}
fn bar() {
    baz(foo();$0);
}

After this PR

fn foo() {}
fn baz(_: impl FnOnce()) {}
fn bar() {
    baz(foo()$0);
}

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 13, 2025
@A4-Tacks A4-Tacks force-pushed the no-semicolon-in-arg-list branch from 8fdac80 to b55c904 Compare November 13, 2025 11:13
@A4-Tacks
Fix complete unit return semicolon in arg-list
7890856 
Example
---
```rust
fn foo() {}
fn baz(_: impl FnOnce()) {}
fn bar() {
    baz(fo$0);
}
```

**Before this PR**

```rust
fn foo() {}
fn baz(_: impl FnOnce()) {}
fn bar() {
    baz(foo();$0);
}
```

**After this PR**

```rust
fn foo() {}
fn baz(_: impl FnOnce()) {}
fn bar() {
    baz(foo()$0);
}
```
@A4-Tacks A4-Tacks force-pushed the no-semicolon-in-arg-list branch from b55c904 to 7890856 Compare November 13, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Completing a function with return type () inserts a semicolon even when in an expression

2 participants

@A4-Tacks @rustbot