Skip to content

Conversation

@Veykril
Copy link
Member

@Veykril Veykril commented Nov 17, 2025

  • Rowan's green nodes are super drop heavy and as lru eviction happens on cancellation this can block for quite some time, especially after cache priming
  • Likewise the span map dropping is fairly heavy, so we offload that too
  • Delay initial cache priming until proc macros are loaded as we otherwise load up a bunch of garbage (stale IDs) into salsa
  • in crate graph construction we were repeatedly probing the cargo binary path for every crate, thats done once now (and also more correctly)
  • Lastly we also now prime the crate lang item queries, as those will be hit by the symbol map which will otherwise walk the entire crate dependency tree in a single worker again, making our parallel efforts partially pointless

Rowan's green nodes are super drop heavy and as lru eviction happens on cancellation this can block for quite some time, especially after cache priming
@Veykril Veykril changed the title perf: Various perf improvements perf: Improve start up time Nov 17, 2025
@Veykril Veykril marked this pull request as ready for review November 17, 2025 14:22
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 17, 2025
@Veykril Veykril added this pull request to the merge queue Nov 18, 2025
Merged via the queue into rust-lang:master with commit d7aeed0 Nov 18, 2025
15 checks passed
@Veykril Veykril deleted the push-xluyprrqpzxz branch November 18, 2025 12:26
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants