fix Display scope inlay hints after closing brace for more types of blocks #18833 #21077
+334
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #18833
Extended the closing-brace hint matcher to recognize MatchArmList nodes and many more BlockExpr parents (loops/while let/for/if+else/let else/match arms) while also prefixing function labels with qualifiers such as async/const/unsafe.
Added reusable helpers for qualifier formatting, trimmed snippet extraction with sane defaults, and label builders for for, if,
let else, match/arms so new scopes produce concise, truncated captions instead of raw syntax.Refreshed the test suite with an async fn coverage case plus a new expect_test that locks down the added block kinds and match-arm behavior, ensuring future regressions are caught without fighting //^ annotations.