fix: include all target types with paths outside package root #21098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Aditya-PS-05
changed the title
Veykril
reviewed
Nov 23, 2025
Member
There was a problem hiding this comment.
lets sort -> dedup include here as with this change we will likely get duplicates (and I don't trust our vfs code here that it can work well with dupes)
Veykril
approved these changes
Nov 23, 2025
Member
|
Thanks! |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #21072
The issue was that only the lib targets with custom paths were added to the source root includes. So binary (and other) targets failed when their path was set to a location outside the cargo package directory.
The fix removes the filter that restricted this behavior to only lib, thus allowing all target types (Bin, Example, Test, etc.) with custom paths to have their parent directories included in source roots.