Skip to content

Fix not fill guarded match arm for add_missing_match_arms #21111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2025
Merged

Fix not fill guarded match arm for add_missing_match_arms #21111

merged 1 commit into from
Nov 23, 2025

Conversation

@A4-Tacks
Copy link
Member

@A4-Tacks A4-Tacks commented Nov 23, 2025

Example

enum Foo { A, B }
fn main() {
    match Foo::A {
        Foo::A if false => todo!(),
    }
}

Before this PR

enum Foo { A, B }
fn main() {
    match Foo::A {
        Foo::A if false => todo!(),
        Foo::B => todo!(),
    }
}

After this PR

enum Foo { A, B }
fn main() {
    match Foo::A {
        Foo::A if false => todo!(),
        Foo::A => todo!(),
        Foo::B => todo!(),
    }
}

@A4-Tacks
Fix not fill guarded match arm for add_missing_match_arms
480561b 
Example
---
```rust
enum Foo { A, B }
fn main() {
    match Foo::A {
        Foo::A if false => todo!(),
    }
}
```

**Before this PR**

```rust
enum Foo { A, B }
fn main() {
    match Foo::A {
        Foo::A if false => todo!(),
        Foo::B => todo!(),
    }
}
```

**After this PR**

```rust
enum Foo { A, B }
fn main() {
    match Foo::A {
        Foo::A if false => todo!(),
        Foo::A => todo!(),
        Foo::B => todo!(),
    }
}
```
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2025
Veykril
Veykril approved these changes Nov 23, 2025
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Veykril Veykril added this pull request to the merge queue Nov 23, 2025
Merged via the queue into rust-lang:master with commit 9422cf5 Nov 23, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2025
@A4-Tacks A4-Tacks deleted the fill-guarded-match-arm branch November 23, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Veykril Veykril Veykril approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@A4-Tacks @Veykril @rustbot