internal: Make ModuleId a tracked struct
#21178
Merged
+1,168
−1,263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
tracked-modules
branch
2 times, most recently
from
10fcf0b to
9694549
Compare
Contributor
|
Does this still increase memory usage? |
Veykril
force-pushed
the
tracked-modules
branch
from
9694549 to
6d13f63
Compare
Member
Author
|
Seems like it saves ~3mb now |
Veykril
force-pushed
the
tracked-modules
branch
4 times, most recently
from
5eae62d to
51f55eb
Compare
Veykril
changed the title
ModuleId a tracked structModuleId a tracked struct
optimize some stuff Optimize `pub(crate)` visibility resolution Optimize private visibility resolution
Veykril
force-pushed
the
tracked-modules
branch
from
51f55eb to
64cabd8
Compare
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #20001
Also turns
BlockLocinto a tracked struct cc #16176