Skip to content

Fix nested expr missing semicolon in incomplete-let #21198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChayimFriedman2 merged 1 commit into from
Dec 3, 2025
Merged

Fix nested expr missing semicolon in incomplete-let #21198

ChayimFriedman2 merged 1 commit into from
Dec 3, 2025
+63 −3

Conversation

@A4-Tacks
Copy link
Member

@A4-Tacks A4-Tacks commented Dec 3, 2025

Example

fn main() {
    let x = &$0
}

Before this PR

fn main() {
    let x = &loop {
        $0
    }
}

After this PR

fn main() {
    let x = &loop {
        $0
    };
}

@A4-Tacks
Fix nested expr missing semicolon in incomplete-let
109251d 
Example
---
```rust
fn main() {
    let x = &$0
}
```

**Before this PR**

```rust
fn main() {
    let x = &loop {
        $0
    }
}
```

**After this PR**

```rust
fn main() {
    let x = &loop {
        $0
    };
}
```
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 3, 2025
ChayimFriedman2
ChayimFriedman2 approved these changes Dec 3, 2025
View reviewed changes
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ChayimFriedman2 ChayimFriedman2 added this pull request to the merge queue Dec 3, 2025
Merged via the queue into rust-lang:master with commit 0b6dc86 Dec 3, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 3, 2025
@A4-Tacks A4-Tacks deleted the nested-incomplete-let-semi branch December 3, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChayimFriedman2 ChayimFriedman2 ChayimFriedman2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@A4-Tacks @ChayimFriedman2 @rustbot