Skip to content

Defer cargo check until after workspace load #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2020
Merged

Defer cargo check until after workspace load #2824

merged 2 commits into from
Jan 13, 2020

Conversation

@kiljacken
Copy link
Contributor

@kiljacken kiljacken commented Jan 13, 2020 •
edited
Loading

Fixes #2822

@kiljacken kiljacken mentioned this pull request Jan 13, 2020
Closed
kjeremy
kjeremy reviewed Jan 13, 2020
View reviewed changes
kjeremy
kjeremy approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@kjeremy kjeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested and it works!

@kiljacken kiljacken marked this pull request as ready for review January 13, 2020 16:48
@kiljacken
Copy link
Contributor Author

kiljacken commented Jan 13, 2020

bors r+

bors bot added a commit that referenced this pull request Jan 13, 2020
@bors @kiljacken
Merge #2824
27abd4a 
2824: Defer cargo check until after workspace load r=kiljacken a=kiljacken

Fixes #2822

Co-authored-by: Emil Lauridsen <mine809@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 13, 2020

Build succeeded

  • Rust (macos-latest)
  • Rust (ubuntu-latest)
  • Rust (windows-latest)
  • TypeScript

@bors bors bot merged commit c774850 into rust-lang:master Jan 13, 2020
@kiljacken kiljacken deleted the defer-cargo-check branch January 13, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kjeremy kjeremy kjeremy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider only running cargo check after the workspace has been loaded

2 participants

@kiljacken @kjeremy