fix(mixed): fixed a couple of typos and added a todo #2865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks! bors r+ |
Contributor
Build succeeded
|
edwin0cheng
reviewed
Jan 17, 2020
| write!(rustfmt.stdin.take().unwrap(), "{}", text)?; | ||
| let output = rustfmt.wait_with_output()?; | ||
| let stdout = String::from_utf8(output.stdout)?; | ||
| // TODO: update the preable: replace ra_tools with the relevant path |
Contributor
There was a problem hiding this comment.
We have a no todo check, but seem like it does not parse xtask itself? 😃
Contributor
There was a problem hiding this comment.
Seems like it.
@Veetaha We tend to use // FIXME for things like this, just for future use.
Contributor
|
So that one can use `TODO` to make sure some *is* fixed before getting
merged. Ie, it is a feature that, if you have `TODO` comment, the CI will
fail, so you can actively use this to leave reminders for yourself when
working with big changes.
It can be argued that polarity is flipped, and that `FIXME` is the one that
should fail the CI, but here we just follow rust-lang/rust precedent.
…On Fri, 17 Jan 2020 at 10:13, Veetaha ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In xtask/src/lib.rs
<#2865 (comment)>
:
> @@ -53,6 +53,7 @@ fn reformat(text: impl std::fmt::Display) -> Result<String> {
write!(rustfmt.stdin.take().unwrap(), "{}", text)?;
let output = rustfmt.wait_with_output()?;
let stdout = String::from_utf8(output.stdout)?;
+ // TODO: update the preable: replace ra_tools with the relevant path
@edwin0cheng <https://github.com/edwin0cheng> @kiljacken
<https://github.com/kiljacken> but why no to-dos? I can even see them all
over the codebase
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#2865>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANB3M44NDMB6MYPVW3O2NTQ6FZDHANCNFSM4KH5DC6A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a couple of typos and added a todo while studying the codebase.