Skip to content

Improve parameter hints a bit & add emacs support #2875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2020
Merged

Improve parameter hints a bit & add emacs support #2875

merged 1 commit into from
Jan 18, 2020

Conversation

@flodiebold
Copy link
Member

@flodiebold flodiebold commented Jan 18, 2020

  • just include the name, not e.g. mut
  • don't return empty hints (or _)

CC @brotzeit for the Emacs change

@flodiebold
Improve parameter hints a bit & add emacs support
18ec4e3 
 - just include the name, not e.g. `mut`
 - don't return empty hints (or `_`)
@matklad
Copy link
Contributor

matklad commented Jan 18, 2020

bors r+

bors bot added a commit that referenced this pull request Jan 18, 2020
@bors @flodiebold
Merge #2875
3a7724e 
2875: Improve parameter hints a bit & add emacs support r=matklad a=flodiebold

 - just include the name, not e.g. `mut`
 - don't return empty hints (or `_`)

CC @brotzeit for the Emacs change

Co-authored-by: Florian Diebold <flodiebold@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 18, 2020

Build succeeded

  • Rust (macos-latest)
  • Rust (ubuntu-latest)
  • TypeScript

@bors bors bot merged commit 18ec4e3 into rust-lang:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@flodiebold @matklad