Skip to content

Support unnamed arguments in function pointers #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 12, 2020
Merged

Support unnamed arguments in function pointers #3127

merged 4 commits into from
Feb 12, 2020

Conversation

@hanmertens
Copy link
Contributor

@hanmertens hanmertens commented Feb 12, 2020

Fixes #3089

@kiljacken
Copy link
Contributor

kiljacken commented Feb 12, 2020

Would you mind adding a test to the comment just above your change?

@hanmertens
Copy link
Contributor Author

hanmertens commented Feb 12, 2020

I'm not entirely sure how the tests work but I assume this should do the trick.

@edwin0cheng
Copy link
Contributor

edwin0cheng commented Feb 12, 2020

CI falied, @hanmertens Would you mind to run cargo xtask codegen and commit the generated test case too. ?

@hanmertens
Copy link
Contributor Author

hanmertens commented Feb 12, 2020

I've run cargo xtask codegen, and cargo test in the ra_syntax crate, I hope that fixes it.

@edwin0cheng
Copy link
Contributor

edwin0cheng commented Feb 12, 2020

Thanks.
bors r+

bors bot added a commit that referenced this pull request Feb 12, 2020
@bors @hanmertens
Merge #3127
5e464d0 
3127: Support unnamed arguments in function pointers r=edwin0cheng a=hanmertens

Fixes #3089

Co-authored-by: Han Mertens <hanmertens@outlook.com>
@bors
Copy link
Contributor

bors bot commented Feb 12, 2020

Build succeeded

  • Rust (macos-latest)
  • Rust (ubuntu-latest)
  • Rust (windows-latest)
  • TypeScript

@bors bors bot merged commit bed9c08 into rust-lang:master Feb 12, 2020
@hanmertens hanmertens deleted the unnamed-argument-in-function-pointer branch February 12, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unnamed argument in type alias parsed incorrectly

3 participants

@hanmertens @kiljacken @edwin0cheng