Skip to content

Minor #3134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2020
Merged

Minor #3134

merged 2 commits into from
Feb 14, 2020

Conversation

@matklad
Copy link
Contributor

@matklad matklad commented Feb 14, 2020

No description provided.

@matklad
Copy link
Contributor Author

matklad commented Feb 14, 2020

bors r+
🤖

bors bot added a commit that referenced this pull request Feb 14, 2020
@bors @matklad
Merge #3134
6798ef0 
3134: Minor r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
lnicola
lnicola reviewed Feb 14, 2020
View reviewed changes
xtask/src/install.rs
anyhow::bail!(
bail!(
"Could not install the Visual Studio Code extension. \
Please make sure you have at least NodeJS 10.x together with the latest version of VS Code installed and try again."
Copy link
Member

@lnicola lnicola Feb 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12?

@bors
Copy link
Contributor

bors bot commented Feb 14, 2020

Canceled

@matklad
Copy link
Contributor Author

matklad commented Feb 14, 2020

bors r+

bors bot added a commit that referenced this pull request Feb 14, 2020
@bors @flodiebold @matklad
Merge #3133 #3134
4165bfd 
3133: Move hir_fmt code to display module r=matklad a=flodiebold



3134: Minor r=matklad a=matklad



Co-authored-by: Florian Diebold <florian.diebold@freiheit.com>
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 14, 2020

Canceled

@matklad
Copy link
Contributor Author

matklad commented Feb 14, 2020

bors r+

bors bot added a commit that referenced this pull request Feb 14, 2020
@bors @flodiebold @matklad
Merge #3133 #3134
60ca023 
3133: Move hir_fmt code to display module r=matklad a=flodiebold



3134: Minor r=matklad a=matklad



Co-authored-by: Florian Diebold <florian.diebold@freiheit.com>
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@bors bors bot merged commit bd3a41c into rust-lang:master Feb 14, 2020
@matklad matklad deleted the dev branch March 4, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lnicola lnicola lnicola left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matklad @lnicola