Improve RA version display

[edwin0cheng]

There are 2 problems of current implementation for displaying current version of RA binary:

1. If that binary is coming from built by source, the REV may not be updated somehow. (See discussion in Zuilp)

2. We must go through the VSCode debugger console to see the output of console.log.

This PR implemented a new VSCode command "Show RA Version" to display the version, which fixed the first problem. And added some rerun-if flags in build.rs to fix the second one.

[edwin0cheng]

PS: Thanks @bjorn3 for idea of git head rerun flags.

[lnicola]

Maybe we can stop logging to console if we add that command?

[bjorn3]

Keeping it leaves all information necessary for debugging in one place.

[lnicola]

Yeah, but I feel we should log less stuff to console, possibly in favor of the output channel.

[edwin0cheng]

I don’t have any strong opinion about it.

[Veetaha]

Logging infrastructure is not yet designed well. @matklad made some proposals around that here. Let's leave it for the debugging purposes for now (it does help a lot)

[Veetaha]

FYI just created an issue about logging #3250

[Veetaha]

Hmm, var is deprecated.

Now we use the following analogies
Rust let ->TypeScript const
Rust let mut -> TypeScript let
Also variables in TypeScript are generally camelCase...

Anyway, I'd like to propose the following:
Let's make getServerVersion() public and add logic for obtaining the commit hash to command handler (to keep it simple).

export function serverVersion(): Cmd {
    return ctx => {
        const { serverSource } = ctx.config;
     
        if (!serverSource) { 
            /* no prebuilt binary for this platform and no explicit path to binary specified */
        }  
        
        if (serverSource.type === BinarySource.GithubRelease) {
             const releaseName = getServerVersion(serverSource.storage);
             ...
        }

        const serverPath = serverSource.type === BinarySource.ExplicitPath
            ? serverSource.path
            : path.join(serverSource.dir, serverSource.file);

        const commitHash = spawnSync(serverPath, ["--version"], { encoding: "utf8" }).stdout;
        ...
    };
}

[edwin0cheng]

Hmm, var is deprecated.

Oh.. My main programming language in my current day job is C# 4.0 (Unity). It is so easy to mix up all different languages syntax.. T_T

[Veetaha]

Logging infrastructure is not yet designed well. @matklad made some proposals around that here. Let's leave it for the debugging purposes for now (it does help a lot)

[matklad]

bors r+

[edwin0cheng]

Seem like bors is stuck. Rebased.

bors retry

[bors]

Build succeeded

• Rust (macos-latest)
• Rust (ubuntu-latest)
• Rust (windows-latest)
• TypeScript

[matklad]

Also, big 👍 from me on solving the general problem of "how do we find which rust-analyzer is used by this user" :)

[Veetaha]

What about adding the release name to the message if the user utilizes prebuilt binaries?