Refactoring fetchArtifactReleaseInfo() #3295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 24, 2020 21:13
Veetaha
changed the title
lnicola
approved these changes
Feb 24, 2020
matklad
reviewed
Feb 24, 2020
| const artifact = release.assets.find(artifact => artifact.name === artifactFileName); | ||
|
|
||
| if (!artifact) return null; | ||
| if (!artifact) throw new Error( |
Contributor
There was a problem hiding this comment.
Let's add {} here: I find that a good rule of thumb is to omit {} iff the body fits on the same line as the condtion
Contributor
Author
There was a problem hiding this comment.
I thought we merge optimistically, but yes, you are right 😅 )
Contributor
|
bors r+ |
Contributor
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-unnecessary-type-assertion.md
I fact this rule doesn't work when you put an unnecessary non-null assertion in an expression (as we had
(awat f())!, but it is useful in other cases...Closes #3295, i guess...