Skip to content

Conversation

@Veetaha
Copy link
Contributor

@Veetaha Veetaha commented Feb 27, 2020

See this zulip thread for more details.

@Veetaha
Copy link
Contributor Author

Veetaha commented Feb 27, 2020

@lnicola @matklad
I somehow can't add reviewers here:
image

@lnicola
Copy link
Member

lnicola commented Feb 27, 2020

Does this actually work? I'm impressed 👍.

@lnicola lnicola requested review from lnicola and matklad February 27, 2020 20:08
@Veetaha
Copy link
Contributor Author

Veetaha commented Feb 27, 2020

@matklad I get the following error:
image

@Veetaha
Copy link
Contributor Author

Veetaha commented Feb 27, 2020

@lnicola
ra_feature_flags

@Veetaha
Copy link
Contributor Author

Veetaha commented Feb 27, 2020

Also, I am not 100% sure that the description for lsp.diagnostics feature flag is correct...

@matklad
Copy link
Contributor

matklad commented Feb 28, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 28, 2020

@bors bors bot merged commit 2d5e54e into rust-lang:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants