Skip to content

Conversation

@JoshMcguigan
Copy link
Contributor

Thanks @matklad for the detailed explanation on #2377. I believe this fixes it.

One thing I'm not sure about is you said the fix would involve changing crates/ra_hir_def/src/path/lower/lower.rs, but I only changed crates/ra_hir_def/src/path/lower/lower_use.rs. I'm not sure what kind of test code I'd have to write to expose the issue in lower.rs, but I'd be happy to add it if you are able to provide additional guidance.

closes #2377

@JoshMcguigan
Copy link
Contributor Author

I just added a test to crates/ra_ide/src/completion/complete_dot.rs to ensure this completion works, and it does not. So this PR should be considered WIP for now.

I'm going to dig into why this completion would still not be working, but I'm open to any guidance.

@JoshMcguigan
Copy link
Contributor Author

See my latest commit for the change to crates/ra_hir_def/src/path/lower/lower.rs which seems to solve the actual completion bug. I believe this PR is now ready for review.

@flodiebold
Copy link
Member

LGTM, thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 1, 2020

@bors bors bot merged commit ea67e23 into rust-lang:master Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

super::super shows autocompletions for super

2 participants