Fix regression from #3451

[edwin0cheng]

There is a regression from #3451 such that the following code has failed to parse in raw item collecting phase:

macro_rules! with_std { 
 	($($i:item)*) => ($(#[cfg(feature = "std")]$i)*) 
}

with_std! {
	mod macros;
	mod others;
}

Rationale

We always assume the last token of an statement will not end with a whitespace, which is true. It is because in parsing phase, we always emit SyntaxNode before any whitespace. Such that in various parts of RA code, we solely check the semi-colon by using SyntaxNode::last_child_token() == ";" .

However, in #3451, we insert some whitespaces between puncts such that we broke above assumption. This PR fixed this bug by make sure we don't add any whitespace if it is a semicolon.

[edwin0cheng]

PS: This bug is a pretty hard to trace.... :(

[matklad]

PS: This bug is a pretty hard to trace.... :(

I wonder if we should have

impl SyntaxNode {
    fn check_invariants(&self)
}

which would, for example, check that there's no floating whitespace and which we can debug_assert in macro expansion and parsing

bors r+

[bors]

Build succeeded

• Rust (macos-latest)
• Rust (ubuntu-latest)
• Rust (windows-latest)
• TypeScript