-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Improvements for eslint (and try switching to prettier) #3647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
05000cc
Add typing annotation for eslint config
darinmorrison 6472051
Use recommended eslint and typescript-eslint rules
darinmorrison 512d360
Fix lints
darinmorrison 681b036
Switch to prettier instead of tsfmt
darinmorrison dbc069f
Configure eslint to use prettier
darinmorrison 8b6ad20
Run prettier
darinmorrison 8be009d
Adjust eslint rules
darinmorrison 2cec955
Work on formatting
darinmorrison c1a4caa
Fix instance of @typescript-eslint/no-misused-promises
darinmorrison File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,52 @@ | ||
| // @ts-check | ||
|
|
||
| /** @type { import('eslint').Linter.Config } */ | ||
| module.exports = { | ||
| "env": { | ||
| "es6": true, | ||
| "node": true | ||
| env: { | ||
| es6: true, | ||
| node: true, | ||
| }, | ||
| "parser": "@typescript-eslint/parser", | ||
| "parserOptions": { | ||
| "project": "tsconfig.json", | ||
| "sourceType": "module" | ||
| parser: '@typescript-eslint/parser', | ||
| parserOptions: { | ||
| project: 'tsconfig.json', | ||
| sourceType: 'module', | ||
| }, | ||
| "plugins": [ | ||
| "@typescript-eslint" | ||
| plugins: ['@typescript-eslint'], | ||
| extends: [ | ||
| 'eslint:recommended', | ||
| 'plugin:@typescript-eslint/eslint-recommended', | ||
| 'plugin:@typescript-eslint/recommended-requiring-type-checking', | ||
| 'plugin:@typescript-eslint/recommended', | ||
| 'plugin:prettier/recommended', | ||
| 'prettier', | ||
| 'prettier/@typescript-eslint', | ||
| ], | ||
| "rules": { | ||
| "camelcase": ["error"], | ||
| "eqeqeq": ["error", "always", { "null": "ignore" }], | ||
| "no-console": ["error"], | ||
| "prefer-const": "error", | ||
| "@typescript-eslint/member-delimiter-style": [ | ||
| "error", | ||
| rules: { | ||
| camelcase: 'error', | ||
| eqeqeq: ['error', 'always', { null: 'ignore' }], | ||
| 'no-console': 'error', | ||
| 'prefer-const': 'error', | ||
| '@typescript-eslint/explicit-function-return-type': ['warn', { allowExpressions: true }], | ||
| '@typescript-eslint/member-delimiter-style': [ | ||
| 'error', | ||
| { | ||
| "multiline": { | ||
| "delimiter": "semi", | ||
| "requireLast": true | ||
| multiline: { | ||
| delimiter: 'semi', | ||
| requireLast: true, | ||
| }, | ||
| "singleline": { | ||
| "delimiter": "semi", | ||
| "requireLast": false | ||
| } | ||
| } | ||
| ], | ||
| "@typescript-eslint/semi": [ | ||
| "error", | ||
| "always" | ||
| singleline: { | ||
| delimiter: 'semi', | ||
| requireLast: false, | ||
| }, | ||
| }, | ||
| ], | ||
| "@typescript-eslint/no-unnecessary-type-assertion": "error" | ||
| } | ||
| '@typescript-eslint/no-inferrable-types': 'off', | ||
| '@typescript-eslint/no-namespace': 'off', | ||
| '@typescript-eslint/no-non-null-assertion': 'off', | ||
| '@typescript-eslint/no-unnecessary-type-assertion': 'error', | ||
| '@typescript-eslint/no-unused-vars': ['warn', { argsIgnorePattern: '^_' }], | ||
| '@typescript-eslint/no-use-before-define': 'off', | ||
| '@typescript-eslint/unbound-method': 'off', | ||
| '@typescript-eslint/semi': ['error', 'always'], | ||
| }, | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // @ts-check | ||
|
|
||
| /** @type { import('prettier').Options } */ | ||
| module.exports = { | ||
| bracketSpacing: true, | ||
| jsxBracketSameLine: true, | ||
| printWidth: 100, | ||
| semi: true, | ||
| singleQuote: true, | ||
| tabWidth: 4, | ||
| trailingComma: 'all', | ||
| useTabs: false, | ||
| overrides: [ | ||
| { | ||
| files: '*.ts', | ||
| options: { | ||
| parser: 'typescript', | ||
| }, | ||
| }, | ||
| ], | ||
| }; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We intentionally don't use recommended: #3041
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use it, but the irrelevant rules are explicitly turned off down bellow.