Upgrade Chalk #3744
Merged
Upgrade Chalk #3744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
approved these changes
Mar 27, 2020
Contributor
|
@flodiebold do we want to get this into today's release? |
Member
Author
|
I don't think there's any upside, so let's wait until after. |
The big change here is counting binders, not variables (rust-lang/chalk#360). We have to adapt to the same scheme for our `Ty::Bound`. It's mostly fine though, even makes some things more clear.
Member
Author
|
Upgraded again. This one required some more changes because of rust-lang/chalk#360. |
Contributor
|
Hm, let's try to get this into today's release at least (unless you strongly object) :) I think that, by updating chalk frequently, we should be able to find regressions quicker. bors r+ |
Contributor
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
Contributor
Build succeeded |
Member
Author
|
Yeah, also I wouldn't want to leave this lying around for long because of merge conflicts 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.