Implement assist "Reorder field names" #3925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffreycopin
force-pushed
the
reorder_fields
branch
from
6f92f7f to
730a927
Compare
matklad
reviewed
Apr 10, 2020
| } | ||
|
|
||
| fn struct_definition(path: &ast::Path, sema: &Semantics<RootDatabase>) -> Option<Struct> { | ||
| match sema.resolve_path(path) { |
Contributor
There was a problem hiding this comment.
Ideally this should use variant_resolutions and not just resolve_paths, but it's not clear how to best expose this API for an IDE, so I guess this is ok as an initial impl
Contributor
|
bors try (looks like CI is failing?) |
Contributor
tryBuild failed |
Contributor
|
bors r+ |
Contributor
Author
|
Indeed, I had not generated the documentation after adding the doc comment. |
Contributor
Build succeeded |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the "Reorder record fields" assist as discussed in issue #3821 .
Adding a
RecordFieldPatvariant to thePatenum seemed like the easiest way to handle theRecordPatchildren as a single sequence of elements, maybe there is a better way ?