Look up trait impls by self type #3944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Apr 11, 2020
| .flat_map(|m| m.values().flat_map(|v| v.iter().copied())) | ||
| } | ||
|
|
||
| pub fn lookup_impl_defs_for_trait_and_ty( |
Contributor
There was a problem hiding this comment.
Do we need both methods public? If we do, than perhaps make self-ty non optional and make the caller write the match?
Member
Author
There was a problem hiding this comment.
Did the latter, how about now?
This speeds up inference in analysis-stats by ~30% (even more with the recursive solver).
flodiebold
force-pushed
the
trait-impl-index
branch
from
4cf2a00 to
a2783df
Compare
Contributor
|
bors r+ |
Contributor
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up inference in analysis-stats by ~30% (even more with the recursive solver).
There's a slight difference in inferred types, which I think comes from pre-existing wrong handling of error types in impls, so I think it's fine.