Skip to content

Conversation

@CodeSandwich
Copy link
Contributor

The default parentModule shortcut conflicts with VSCode's built-in undo selection

The default parentModule shortcut conflicts with VSCode's built-in undo selection
@matklad
Copy link
Contributor

matklad commented Apr 15, 2020

Let's just remove this shortcut by defualt.

@CodeSandwich
Copy link
Contributor Author

Is it necessary? Does the ctrl+shift+u shortcut conflict with something else? Without the default shortcut barely anybody is going to use that feature, which itself is nice as a way to save a click or two.

@matklad
Copy link
Contributor

matklad commented Apr 15, 2020

Yeah, this also makes sense

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 15, 2020

@bors bors bot merged commit f1a07db into rust-lang:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants