Skip to content

Fix a bunch of unresovled references #4036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2020
Merged

Fix a bunch of unresovled references #4036

merged 2 commits into from
Apr 18, 2020

Conversation

@matklad
Copy link
Contributor

@matklad matklad commented Apr 18, 2020

bors r+
🤖

bors bot added a commit that referenced this pull request Apr 18, 2020
@bors @matklad
Merge #4036
27991eb 
4036: Fix goto definition for record patterns r=matklad a=matklad



bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 18, 2020

Build failed:

@matklad
Correctly infer types in guard expressions
b79fd82 
The root cause was that we forgot to add bindings from the arm to the
guard expression

closes rust-lang#3980
@matklad matklad changed the title Fix goto definition for record patterns Fix a bunch of unresovled references Apr 18, 2020
@matklad
Copy link
Contributor Author

matklad commented Apr 18, 2020

These two issues jumped at me after doing #4034

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 18, 2020

Build succeeded:

@bors bors bot merged commit 36840bd into rust-lang:master Apr 18, 2020
@matklad matklad deleted the goto-pat-field branch April 18, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@matklad