Skip to content

Conversation

@jonas-schievink
Copy link
Contributor

This is usually the right thing, and previously would launch a stale r-a server.

@matklad
Copy link
Contributor

matklad commented Apr 28, 2020

Shouldn’t we run both tasks on build?

@jonas-schievink
Copy link
Contributor Author

Probably, yeah. I'd have to make an extra task then, since you can only specify one in the launch configuration.

@jonas-schievink
Copy link
Contributor Author

It seems that you can't make a launch configuration depend on a background task (it will wait indefinitely for the task to finish)

@jonas-schievink
Copy link
Contributor Author

Okay this seems to work, but I have no clue about npm or TypeScript

@matklad
Copy link
Contributor

matklad commented Apr 28, 2020

bors r+

I feel like this can be in theory trimmed down a bit, as it seems like we shouldn't have that many different compbinations. but I also don't have any specific suggestions here, as I don't use tasks at all :)

@bors
Copy link
Contributor

bors bot commented Apr 28, 2020

@bors bors bot merged commit 0d7c997 into rust-lang:master Apr 28, 2020
@felix91gr
Copy link

I'm sorry to bother you guys, but what does this do exactly? Are you rebuilding r-a?

But r-a is (more or less) a compiler.
Wouldn't rebuilding it take way too long? Therefore, I'm assuming I got it wrong and it's something else that's being rebuilt.
Unless it's being rebuilt incrementally?

@flodiebold
Copy link
Member

@felix91gr As far as I know, these are tasks for use while developing rust-analyzer in VSCode. And yeah, an incremental build of rust-analyzer doesn't take that long.

@jonas-schievink jonas-schievink deleted the fix-tasks-deps branch June 5, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants