Use specific pattern when translating if-let-else to match #4204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We *probably* should actually use the same machinery here, as we do for fill match arms, but just special-casing options and results seems to be a good first step.
Contributor
|
Build succeeded: |
flodiebold
reviewed
Apr 29, 2020
| let pattern = sema | ||
| .type_of_pat(&pat) | ||
| .and_then(|ty| TryEnum::from_ty(sema, &ty)) | ||
| .map(|it| it.sad_pattern()) |
Member
There was a problem hiding this comment.
what if I wrote if let None = something() {} else {}?
Contributor
Author
There was a problem hiding this comment.
match None {
None => 2,
None => 1,
};
😭
I guess that's the case where it becomes easier to do this properly (via exhaustiveness analysis) rather than via heuristics....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We probably should actually use the same machinery here, as we do
for fill match arms, but just special-casing options and results seems
to be a good first step.
bors r+
🤖