Syntactic highlighting of NAME_REF for injections #4876
Conversation
|
|
||
| stack.push(); | ||
| for mut h in analysis.highlight(tmp_file_id).unwrap() { | ||
| for mut h in analysis.highlight_injection(tmp_file_id).unwrap() { |
There was a problem hiding this comment.
Let's use super::highlight(&analysis.db, tmp_file_id, None, false) here to avoid adding a new method to Analysis.
Also, looking at this I now realize that there's a big problem with cancellation here... Basically, we can't cancel stuff while we are doing highlighting of the injection. Seems bad, long term.
We need some salsa-level magic to solve this in a nicer way...
There was a problem hiding this comment.
As an alternative, wouldn't it be better to parse doc comments (maybe including markdown) directly when parsing the file? This would certainly remove a lot of complexity from the current injection logic (and the extraction part) and maybe one can simulate the steps from https://doc.rust-lang.org/rustdoc/documentation-tests.html in order to get a faithful semantic representation.
This commit adds a function that tries to determine the syntax highlighting class of NAME_REFs based on the usage. It is used for highlighting injections (such as highlighting of doctests) as the semantic logic will most of the time result in unresolved references. It also adds a color to unresolved references in HTML encoding.
ltentrup
force-pushed
the
syntactic-name-ref-highlighting
branch
from
946ec3a to
c4b3db0
Compare
|
bors r+ |
2 participants
This commit adds a function that tries to determine the syntax highlighting class of NAME_REFs based on the usage.
It is used for highlighting injections (such as highlighting of doctests) as the semantic logic will most of the time result in unresolved references.
It also adds a color to unresolved references in HTML encoding.
Follow up of #4683.
Fixes #4809.