Show notification while SSR is in progress #5119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Jun 29, 2020
Contributor
Author
|
Thanks for noticing that. You'll be pleased to know that I've now installed a spellchecker in vscode. I've added a commit to fix the typo. Bors squashes commits right? |
Member
|
It doesn't. You can force push it leave them like this. |
Ideally we would (a) show progress and (b) allow cancellation, but at least now there's some indication to the user that something is happening.
Contributor
|
Yeah, we generally don't have solution yet for analysis progress... Kind of hard to do for lazy setup bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we would (a) show progress and (b) allow cancellation, but at least now there's some indication to the user that something is happening.