Split namespace maps in ItemScope
#5136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 30, 2020 13:23
Reduces memory usage of the CrateDefMap query by ~130 MB on r-a.
matklad
reviewed
Jun 30, 2020
Contributor
Author
|
bors r+ |
Contributor
kjeremy
reviewed
Jun 30, 2020
| .chain(self.values.keys()) | ||
| .chain(self.macros.keys()) | ||
| .chain(self.unresolved.iter()) | ||
| .collect(); |
Contributor
There was a problem hiding this comment.
Do you have to collect here?
Contributor
Author
There was a problem hiding this comment.
Yeah, names have to be deduplicated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces memory usage of the CrateDefMap query by ~130 MB (50%) on r-a.
I was also looking into handling glob imports more efficiently (storing scope chains instead of always duplicating everything into the glob-importing module's scope), but it seems that this already gives the most significant wins.