More memory-efficient impl collection #5175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 1, 2020 15:18
It creates a big map and duplicates lots of impls that are then left lying around
This makes the intention of inherent vs. trait impls somewhat more clear and also fixes (?) an issue where trait impls with an unresolved trait were added as inherent impls instead (hence the test changes).
jonas-schievink
commented
Jul 1, 2020
| mod marker { | ||
| trait Copy {} | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This generated impl used to be recorded as an inherent impl since Copy couldn't be found.
Contributor
|
bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves roughly 90 MB in
ImplsFromDepsQuery, which used to copy the list of all impls from libcore into every crate in the graph. It also stops collecting inherent impls from dependencies entirely, as those can only be located within the crate defining the self type.