Skip to content

Conversation

@lnicola
Copy link
Member

@lnicola lnicola commented Jul 1, 2020

No description provided.

@matklad
Copy link
Contributor

matklad commented Jul 1, 2020

bors r+

bors bot added a commit that referenced this pull request Jul 1, 2020
5180: Disable optimizations for tracing-attributes r=matklad a=lnicola



Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
@bors
Copy link
Contributor

bors bot commented Jul 1, 2020

Build failed:

@lnicola
Copy link
Member Author

lnicola commented Jul 2, 2020

@Veetaha now what? 😀

What's even going on in https://github.com/lodash/lodash/issues/4744, lodash/lodash#4759? 😰

@Veetaha
Copy link
Contributor

Veetaha commented Jul 2, 2020

I don't see a way to specify exclusions for nm audit, so we just need to comment out this step until lodash has published the fix

@lnicola
Copy link
Member Author

lnicola commented Jul 2, 2020

@matklad
Copy link
Contributor

matklad commented Jul 2, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 2, 2020

@bors bors bot merged commit e5f8fb3 into rust-lang:master Jul 2, 2020
@lnicola lnicola deleted the tracing-attributes-noopt branch July 2, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants