Record and suggest assoc. items of traits via ImportMap #5189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Jul 2, 2020
crates/ra_hir_def/src/import_map.rs
Outdated
|
|
||
| /// Maps names of associated items to the item's ID. Only includes items whose defining trait is | ||
| /// exported. | ||
| assoc_map: FxHashMap<String, SmallVec<[AssocItemId; 1]>>, |
Contributor
There was a problem hiding this comment.
Seems like it makes sense to use SmalStr here? Or maybe just fold this into fts and use high-order bit of the value to distingusish ItemInNs from AssocItemId?
Contributor
Author
There was a problem hiding this comment.
I didn't put it in the fst because this is currently always queried exactly. I guess I could filter non-exact assoc. item matches out afterwards though.
Contributor
There was a problem hiding this comment.
Yeah, it seems a bit wasteful to do heap allocation for each assoc item. It shouldn't matter that much (as assoc items are very are), but still
Contributor
Author
There was a problem hiding this comment.
(I went with SmolStr since the FST building code is already cursed enough)
added 2 commits
July 2, 2020 13:34
Contributor
|
bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5115