Skip to content

Implement rust-analyzer feature configuration to tests. #5192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2020
Merged

Implement rust-analyzer feature configuration to tests. #5192

merged 1 commit into from
Jul 2, 2020

Conversation

@daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Jul 2, 2020

Fixes #3198.

I'm unsure if it is desired this way, maybe we want to make a seperate configuration?

daxpedda
daxpedda commented Jul 2, 2020
View reviewed changes
matklad
matklad reviewed Jul 2, 2020
View reviewed changes
Copy link
Contributor

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 2, 2020

Build succeeded:

@bors bors bot merged commit 4cb8bf0 into rust-lang:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@matklad matklad matklad left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test runnables should take cargo features into account

2 participants

@daxpedda @matklad