Cache macro expansion in semantics #5519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-lang#5497 accidentally made syntax highlighting quadratic, due to repeated tokentreeizing of macros.
Member
|
How is the memory usage compared to pre-#5497? |
Contributor
Author
|
That's cache on semantics (so, per-request), so it shouldn't really affect the retained memory we use. Though I indeed wonder if it affects our measurements, let me take a look... |
Contributor
Contributor
Author
|
yup, analysis-stats repots the same memory usage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5497 accidentally made syntax highlighting quadratic, due to
repeated tokentreeizing of macros.
bors r+
🤖