do not add to pub use in assists that insert a use statement
#5658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbr
changed the title
pub use statementspub use statements in assists that insert a use statement
jbr
changed the title
pub use statements in assists that insert a use statementpub use in assists that insert a use statement
Contributor
|
Thanks, looks good! bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5657 , see issue for rationale
Initially I wrote a version of this that changed the signature of
insert_use_statementto take anOption<VisibilityKind>and only add to use statements with the same visibility, but that didn't make sense for any of the current uses ofinsert_use_statement(they all expected private visibility).