Textmate grammar: prevent line comments from breaking block comments (closes #6281) #6320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prevent line comments inside block comments - prevent underscore-prefixed functions and macros from receiving comment scope
Contributor
|
bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6281.
Previously, line comments were able to break block comments by essentially commenting out the closing
*/, resulting in a never-ending comment. This PR splits block comments into a separate repository group to fix this problem.Since the comment scopes also include ignored parameters and inferred types, I've added the change proposed by @bnjjj in #6317, in order to close #6311 as well.