Don't interpret type path as part of visibility. #6333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Oct 23, 2020
Contributor
Yup! |
ArifRoktim
force-pushed
the
pub-parens-typepath
branch
from
33d76f7 to
66a1de7
Compare
Contributor
|
This looks good to go, so marking as ready and bors r+ :) Thanks @ArifRoktim , feel free to send a follow up PR if you want anything changed! |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #5902.
I only check that the next token isn't equal to
T![:], instead of the next two not being equal toT![::]. Is that ok?