Skip to content

Improve Chalk debugging #6336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2020
Merged

Improve Chalk debugging #6336

merged 1 commit into from
Oct 23, 2020

Conversation

@flodiebold
Copy link
Member

@flodiebold flodiebold commented Oct 23, 2020

  • add panic context for the trait goal if CHALK_DEBUG is set
  • print the Chalk program even if we're panicking
  • log goal/solution while TLS is still set

@flodiebold
Improve Chalk debugging
baeb16e 
 - add panic context for the trait goal if CHALK_DEBUG is set
 - print the Chalk program even if we're panicking
 - log goal/solution while TLS is still set
@matklad
Copy link
Contributor

matklad commented Oct 23, 2020

Nice!

bors d+

@bors
Copy link
Contributor

bors bot commented Oct 23, 2020

✌️ flodiebold can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@matklad
Copy link
Contributor

matklad commented Oct 23, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 23, 2020

Build succeeded:

@bors bors bot merged commit ea25ae6 into rust-lang:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flodiebold @matklad @lnicola