Diagnose #[cfg]s in bodies #6339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✌️ jonas-schievink can now approve this pull request. To approve and merge a pull request, simply reply with |
matklad
reviewed
Oct 23, 2020
| **Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir_def/src/diagnostics.rs#L10[diagnostics.rs] | ||
| **Source:** https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir_def/src/diagnostics.rs#L18[diagnostics.rs] | ||
|
|
||
| This diagnostic is triggered if rust-analyzer is unable to discover referred module. |
Contributor
There was a problem hiding this comment.
wait, we should have this gitignored, but this is unrelated to PR
bors d+
Contributor
There was a problem hiding this comment.
bors r+
I have some trouble distinguishing d and r recently...
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR threads diagnostics through body lowering using the
BodySourceMap, and emitsInactiveCodediagnostics for expressions, statements, and match arms that are#[cfg]d out.