Shorter dependency chain #6342
Merged
Shorter dependency chain #6342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Oct 24, 2020
| AssistContext, AssistId, AssistKind, Assists, | ||
| }; | ||
| use crate::{utils::unwrap_trivial_block, AssistContext, AssistId, AssistKind, Assists}; | ||
| use ide_db::ty_filter::TryEnum; |
Contributor
There was a problem hiding this comment.
Very minor and is not required to be fixed, but we put crate:: and other_crate:: deps in different groups: https://github.com/rust-analyzer/rust-analyzer/blob/master/docs/dev/style.md#order-of-imports
matklad
reviewed
Oct 24, 2020
Contributor
matklad
left a comment
matklad
left a comment
There was a problem hiding this comment.
bors r+
bors d+
(in case this conflicts with another .lock changing PR in queue)
| expect![[r#""#]], | ||
| ); | ||
| } | ||
| } |
| use crate::{line_index::LineIndex, symbol_index::SymbolsDatabase}; | ||
|
|
||
| /// `base_db` is normally also needed in places where `ide_db` is used, so this re-export is for convenience. | ||
| pub use base_db; |
Contributor
|
✌️ popzxc can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing implementing suggestions from the
Completion refactoringzulip thread.This PR does the following:
completionsonassistsby moving required functionality intoide_db.call_infocrate intoide_dbas it looks like it fits perfect there.base_dbto theide_dband removes direct dependency onbase_dbfrom other crates.The last point is controversial, I guess, but I noticed that in places where
ide_dbis used,base_dbis also always used. Thus I think the dependency on thebase_dbis implied by the fact ofide_dbinterfaces, and thus it makes sense to just providebase_dbout of the box.