Upgrade Chalk to 0.36 #6415
Merged
Upgrade Chalk to 0.36 #6415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quite a few changes, because Chalk got rid of the `ApplicationTy` nesting.
Member
|
LGTM, but take that with a grain of salt. Unrelated, is the plan still to move to |
Member
Author
|
Yeah. My plan is to first finish the "resolved types" IR that I've been working on for a while now; then the current |
Member
Author
|
I'll take the LGTM as a bors r+ 😉 |
Contributor
Member
|
@flodiebold do we know if there was a perf diff here? |
Member
|
There's https://rust-analyzer.github.io/metrics/, but I haven't dug up the right commit to check (590fdba). It seems a bit inconclusive:
|
Member
|
Hmm okay. Was just a bit curious if the reduced substitutions we use in chalk now helped anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a few changes, because Chalk got rid of the
ApplicationTynesting.