Deny unreachable-pub #6438
Merged
Deny unreachable-pub #6438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
force-pushed
the
no-unreachable-pub
branch
from
0bdc697 to
7533c47
Compare
It's very useful when `pub` is equivalent to "this is crate's public API", let's enforce this! Ideally, we should enforce it for local `cargo test`, and only during CI, but that needs rust-lang/cargo#5034.
matklad
force-pushed
the
no-unreachable-pub
branch
from
7533c47 to
b610118
Compare
Contributor
Author
|
Goinging to partially land this, and then finish later, hopeflly today! bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's very useful when
pubis equivalent to "this is crate's publicAPI", let's enforce this!
Ideally, we should enforce it for local
cargo test, and only duringCI, but that needs rust-lang/cargo#5034.