Skip to content

Add common issues to the bug report template #6468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2020
Merged

Add common issues to the bug report template #6468

merged 1 commit into from
Nov 4, 2020

Conversation

@lnicola
Copy link
Member

@lnicola lnicola commented Nov 4, 2020 •
edited
Loading

Closes #6298

@lnicola lnicola force-pushed the common-issues branch 2 times, most recently from 1299f2d to 019822c Compare November 4, 2020 14:59
@kjeremy
Copy link
Contributor

kjeremy commented Nov 4, 2020

I think this would close #6298

kjeremy
kjeremy reviewed Nov 4, 2020
View reviewed changes
@lnicola lnicola force-pushed the common-issues branch 2 times, most recently from 4ff299d to e63d9e3 Compare November 4, 2020 15:24
bjorn3
bjorn3 reviewed Nov 4, 2020
View reviewed changes
Veykril
Veykril reviewed Nov 4, 2020
View reviewed changes
@flodiebold
Copy link
Member

flodiebold commented Nov 4, 2020 •
edited
Loading

I'd leave out 7 and 8, these aren't so clear-cut and I don't get the impression that we get a lot of duplicates for them.

Also as a general note, in my opinion we should make this as short as possible to make sure people actually check it. So for example I don't know whether having the extension incompatibility in there helps, especially since it's not immediately clear what kinds of problems this matches.

@kjeremy
Copy link
Contributor

kjeremy commented Nov 4, 2020

LGTM

@lnicola
Copy link
Member Author

lnicola commented Nov 4, 2020

I don't know whether having the extension incompatibility in there helps, especially since it's not immediately clear what kinds of problems this matches

We've seen #6461 and cases like this were also discussed in the vscode-rust repo, e.g. rust-lang/vscode-rust#852. I think it's safe to say that they're incompatible.

@flodiebold
Copy link
Member

flodiebold commented Nov 4, 2020

I agree that they're incompatible, I'm just not sure that's worth including here. Especially if we can instead warn about it programmatically (#6463).

@lnicola
Copy link
Member Author

lnicola commented Nov 4, 2020 •
edited
Loading

Let's leave it in here until #6463 is implemented, then we can remove it. I reordered them a little so it ended up at the end of the list. Even if it's not a common issue (though I tend to disagree based on various reports I've seen), it won't hurt to have it in there.

@lnicola
Copy link
Member Author

lnicola commented Nov 4, 2020

bors r=flodiebold

@bors
Copy link
Contributor

bors bot commented Nov 4, 2020

Build succeeded:

@bors bors bot merged commit 678a29e into rust-lang:master Nov 4, 2020
@lnicola lnicola deleted the common-issues branch November 4, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Veykril Veykril Veykril left review comments

@flodiebold flodiebold flodiebold approved these changes

+2 more reviewers

@kjeremy kjeremy kjeremy left review comments

@bjorn3 bjorn3 bjorn3 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create Issue Templates

5 participants

@lnicola @kjeremy @flodiebold @Veykril @bjorn3