Restore semantic token flickering workaround removed in #5697 #6470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6452
Info
Error('busy')workaround for semantic token flickering was removed because the underlying issue was believed to be fixed in VS Code.Changes
provideDocumentSemanticTokens,provideDocumentSemanticTokensEdits, andprovideDocumentRangeSemanticTokensto match the 3 possible middleware hooks defined in https://github.com/microsoft/vscode-languageserver-node/blob/master/client/src/common/semanticTokens.ts#L33nullorundefinedreturn and throws an error with the messagebusyinstead, which prevents the tokens from being removed and re-added (causing the flickering behavior)Tested