Skip to content

Conversation

@charlespierce
Copy link
Contributor

Closes #6452

Info

  • As discussed in Syntax Highlighting in VS Code Flickers when typing quickly #6452, the Error('busy') workaround for semantic token flickering was removed because the underlying issue was believed to be fixed in VS Code.
  • It turns out that the fix isn't yet complete, so this caused flickering of the semantic highlighting when making rapid edits (e.g. typing quickly).
  • This PR restores that workaround and makes it slightly more robust, covering all areas of semantic token middleware.

Changes

Tested

  • Tested locally that the flickering behavior is gone.
  • There don't appear to be any significant tests of the VS Code plugin side of things, other than that it loads. Is there somewhere I can / should add tests to cover this behavior?

@kjeremy
Copy link
Contributor

kjeremy commented Nov 5, 2020

LGTM!

@kjeremy
Copy link
Contributor

kjeremy commented Nov 5, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 5, 2020

@bors bors bot merged commit 7709b6a into rust-lang:master Nov 5, 2020
@charlespierce charlespierce deleted the restore_flicker_fix branch November 9, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Syntax Highlighting in VS Code Flickers when typing quickly

2 participants