Add infer_function_return_type assist #6477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p3achyjr
reviewed
Nov 6, 2020
| fn extract_tail(expr: ast::Expr) -> Option<(ast::Expr, SyntaxToken, bool)> { | ||
| let (ret_ty, tail_expr, insert_pos, wrap_expr) = | ||
| if let Some(closure) = expr.syntax().ancestors().find_map(ast::ClosureExpr::cast) { | ||
| let (tail_expr, wrap_expr) = match closure.body()? { |
There was a problem hiding this comment.
hey--commenting out of curiosity but would this always infer function types for lambdas? Is that something that's wanted?
Member
Author
There was a problem hiding this comment.
It would give you the option to have this assist explicitly annotate the closure return type if you are in the last expression of the closure. This is an action the user would have to trigger. So the user has to trigger the assist to have it annotate the closure with its explicit return type.
The assist name is poorly chosen I think but I couldn't come up with a better name 😅
matklad
reviewed
Nov 6, 2020
matklad
reviewed
Nov 6, 2020
matklad
reviewed
Nov 6, 2020
Contributor
|
bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an assist to insert a functions return type if it hasn't been specified yet by inferring it from the functions tail expression. This assist only becomes active if the cursor is on the tail expression. See #6303 (comment)