Improve autoimports on completion speed #6614
Conversation
* Ignore modules eaferly * Do less completion string rendering
| &ctx.sema, | ||
| ctx.krate?, | ||
| &potential_import_name, | ||
| 50, |
There was a problem hiding this comment.
I wonder what heuristic is used by IntelliJ here to limit the set of auto-import candidates?
There was a problem hiding this comment.
I'll look at it at some point.
There was a problem hiding this comment.
Looks like the results are not limited there at all.
This is the analogue of our imports_locator: https://github.com/intellij-rust/intellij-rust/blob/48d051f0b040e4cad5fc4dac7f07578e801c808e/src/main/kotlin/org/rust/ide/utils/import/ImportCandidatesCollector.kt
and its usage related to completions seems to be here:
https://github.com/intellij-rust/intellij-rust/blob/48d051f0b040e4cad5fc4dac7f07578e801c808e/src/main/kotlin/org/rust/lang/core/completion/RsCommonCompletionProvider.kt#L198
I think we can safely remove the limit from the imports_locator::find_similar_imports invocation, but still have to have the .take(40) or similar in the unqualified_path::fuzzy_completion function to avoid excessive insert imports calculation.
2 participants
Presumably closes #6594
May help #6612