Properly infer tuple patterns when encountering ellipsis #6618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
force-pushed
the
tuple-ellipsis-infer
branch
from
2e2fa02 to
35dd62e
Compare
flodiebold
approved these changes
Nov 24, 2020
Member
flodiebold
left a comment
flodiebold
left a comment
There was a problem hiding this comment.
Looks good, just one small comment!
bors d+
Contributor
|
✌️ Veykril can now approve this pull request. To approve and merge a pull request, simply reply with |
Veykril
force-pushed
the
tuple-ellipsis-infer
branch
from
c4b739c to
a5efefd
Compare
Member
Author
|
bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We basically just split the subpatterns into two halves when the ellipsis is present and then offset the latter half to account for the ignored bindings.
Fixes #6616