Skip to content

Conversation

@SomeoneToIgnore
Copy link
Contributor

Part of #6612

Adds a possibility to disable autoimports:

image

and other experimental completions we might want to add later.

@kjeremy
Copy link
Contributor

kjeremy commented Nov 24, 2020

Code LGTM.

Since it's labeled as experimental we might want to make the default false.

@kjeremy
Copy link
Contributor

kjeremy commented Nov 24, 2020

Actually I'll pull it in since it's not a regression. We can make it false in a follow-up PR if people think that's a good move.

@kjeremy
Copy link
Contributor

kjeremy commented Nov 24, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 24, 2020

@bors bors bot merged commit 9b512f8 into rust-lang:master Nov 24, 2020
@SomeoneToIgnore SomeoneToIgnore deleted the disable-autoimports branch November 25, 2020 06:03
@SomeoneToIgnore
Copy link
Contributor Author

I've made true by default to be consistent with what we do with experimental diagnostics (same) and because not that many people had complained about the autoimports (yet?)

@SomeoneToIgnore SomeoneToIgnore changed the title Gate autoimports begind experimental completions flag Gate autoimports behind the experimental completions flag Nov 25, 2020
@flodiebold
Copy link
Member

TBH, I would just add a completion.autoimport.enable setting. I wouldn't call the autoimport completions experimental, and I don't think there will be so many "experimental" completion types that we need to group them 🤔

@extremegf
Copy link
Contributor

and because not that many people had complained about the autoimports (yet?)

I'm a simple Rust developer and from my perspective buggy auto-complete with imports is better than bug-free limited auto-complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants