Skip to content

Feature/add assist extract module to file #6746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 22, 2020
Merged

Feature/add assist extract module to file #6746

merged 6 commits into from
Dec 22, 2020

Conversation

@sasurau4
Copy link
Contributor

@sasurau4 sasurau4 commented Dec 7, 2020 •
edited
Loading

Fix #6522

Screenshot

TODO

  • Remove all TODO comment
  • Pass the doc test

@kjeremy
Copy link
Contributor

kjeremy commented Dec 7, 2020

I think you need to run cargo xtask codegen

kjeremy
kjeremy reviewed Dec 7, 2020
View reviewed changes
@sasurau4
Copy link
Contributor Author

sasurau4 commented Dec 8, 2020

I ran cargo xtask codegen and no changes occured. I think the CI fail because rustdoc doesn't support multi file annotation. How to fix it?

matklad
matklad reviewed Dec 9, 2020
View reviewed changes
@sasurau4 sasurau4 force-pushed the feature/add-assist-extract-module-to-file branch from 9564847 to 635cda1 Compare December 10, 2020 16:16
@sasurau4 sasurau4 requested review from kjeremy and matklad December 10, 2020 16:17
@sasurau4 sasurau4 force-pushed the feature/add-assist-extract-module-to-file branch from 635cda1 to 4313030 Compare December 11, 2020 14:50
matklad
matklad reviewed Dec 14, 2020
View reviewed changes
@sasurau4 sasurau4 force-pushed the feature/add-assist-extract-module-to-file branch from 4313030 to 8e74d18 Compare December 17, 2020 13:11
@sasurau4 sasurau4 requested a review from matklad December 17, 2020 13:13
@matklad
Copy link
Contributor

matklad commented Dec 19, 2020

Hm, this doesn't seem to quite work yet?

extract-module.mp4

@sasurau4
Copy link
Contributor Author

sasurau4 commented Dec 20, 2020

I look into it.

@sasurau4 sasurau4 force-pushed the feature/add-assist-extract-module-to-file branch from 8e74d18 to 23ed33a Compare December 21, 2020 06:56
@sasurau4
Copy link
Contributor Author

sasurau4 commented Dec 21, 2020

@matklad Fixed not working and I added the screenshot 📷 in PR description.

@matklad
Copy link
Contributor

matklad commented Dec 22, 2020

works for me now, thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 22, 2020

Build succeeded:

@bors bors bot merged commit b98ee07 into rust-lang:master Dec 22, 2020
@sasurau4 sasurau4 deleted the feature/add-assist-extract-module-to-file branch December 22, 2020 11:59
@0x8f701 0x8f701 mentioned this pull request Dec 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kjeremy kjeremy Awaiting requested review from kjeremy

@matklad matklad Awaiting requested review from matklad

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add **Extract Module to File** assist

3 participants

@sasurau4 @kjeremy @matklad