Change HasChildSource::ChildId assoc item to generic param #6879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
changed the title
Veykril
force-pushed
the
childbysource
branch
from
dc8aac9 to
c5dad6a
Compare
matklad
reviewed
Dec 15, 2020
crates/hir_def/src/generics.rs
Outdated
| pub struct SourceMaps { | ||
| pub type_params: ArenaMap<LocalTypeParamId, Either<ast::Trait, ast::TypeParam>>, | ||
| pub lifetime_params: ArenaMap<LocalLifetimeParamId, ast::LifetimeParam>, | ||
| pub(crate) struct SourceMaps { |
Contributor
There was a problem hiding this comment.
Suggested change
| pub(crate) struct SourceMaps { | |
| pub(crate) struct SourceMap { |
a source map can be heterogeneous (see BodySourceMap)
matklad
reviewed
Dec 15, 2020
Contributor
matklad
left a comment
matklad
left a comment
There was a problem hiding this comment.
r=me with SourceMaps singularaized
Veykril
force-pushed
the
childbysource
branch
from
c5dad6a to
1872386
Compare
Veykril
force-pushed
the
childbysource
branch
from
1872386 to
2c67a4a
Compare
Member
Author
|
bors r=matklad |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.